samkhal / marioai

Automatically exported from code.google.com/p/marioai
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Max values in evaluation info are nonsensical #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The values printed out after a run give a (0 out of MAX) rating for all items 
which can be enumerated, however it always just gives a really big number which 
is not representative of the actual number of (enemies, coins, blocks, 
whatever).

It seems upon further investigation that the number is just Interger.MAX which 
is used in LevelGenerator.createLevel in order to set the counters.totalX 
variables.

This might be by design but I thought I'd mention it.

Original issue reported on code.google.com by melin...@gmail.com on 28 Oct 2010 at 7:31

GoogleCodeExporter commented 9 years ago
My reasoning was wrong before, this can be closed for now.  I few times I saw 
values of 262,000 but that was probably related to something else.

Sorry for the spam.

Original comment by melin...@gmail.com on 28 Oct 2010 at 7:43

GoogleCodeExporter commented 9 years ago
I see what was happening now.  It's also because of persistent data in counters 
as mentioned in issue 9.

If you run the steps in that issue you will see that the 2nd run has 291 coins 
like the first run.  Essentially, multiple runs inside the same instance just 
accumulate totals.

Original comment by melin...@gmail.com on 28 Oct 2010 at 9:39

GoogleCodeExporter commented 9 years ago
Thank you for question! That allows me to put more light on this -- we gonna 
change and redevelop Level Generator from scratch soon, based on different 
principles. These are the "values for future parts" of Level Generator. Same as 
booleans named as integers. Definitely it is not going to be MAX_INT of any 
element, so this is just a quick fix and will be change when Level Generator 
changes more mature.
Let me know if that was clear enough, 

I put it Low and we'll close this issue together with 9, when the actual 
feature will be implemented.

Thank you
Sergey

Original comment by Sergey.K...@gmail.com on 28 Oct 2010 at 10:38