Closed suciutwo closed 10 years ago
Looks good! I added some comments.
On Sun, May 4, 2014 at 4:23 PM, Andrew notifications@github.com wrote:
May close issue 6
You can merge this Pull Request by running
git pull https://github.com/suciutwo/code-the-change-projects master
Or view, comment on, or merge it at:
https://github.com/samking/code-the-change-projects/pull/27 Commit Summary
- updating collaborator counts
- display links to edit project you own, let logged out users login to join project
- grammar
- made logout work on all pages
- strong consistency for collaborator model queries
- remove logout url if user is not logged in
- display emails for logged in users working on projects
- fixed logged out user joining project problem
File Changes
- M handlers.pyhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-0(61)
- M index.yamlhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-1(11)
- M models/collaborator.pyhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-2(35)
- M models/project.pyhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-3(7)
- M models/user.pyhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-4(17)
- M views/dashboard.htmlhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-5(2)
- M views/display_project.htmlhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-6(23)
- M views/header.htmlhttps://github.com/samking/code-the-change-projects/pull/27/files#diff-7(4)
Patch Links:
- https://github.com/samking/code-the-change-projects/pull/27.patch
- https://github.com/samking/code-the-change-projects/pull/27.diff
Reply to this email directly or view it on GitHubhttps://github.com/samking/code-the-change-projects/pull/27 .
Thanks!
I made a couple of changes and am about to merge it in. The changes:
May close issue 6