search

sammachin / node-red-contrib-ngrok

ngrok node for node-red
MIT License
7 stars 10 forks source link

Dependency Issue with agent-base <6.0.0 and Node-RED 2.0 #22

Closed sammachin closed 3 years ago

sammachin commented 3 years ago

Hi,

We've detected that your node has a dependency on an old version of agent-base (<6.0.0) , These old versions were patching a core node.js function in a way that could break other libraries - including one we started using in Node-RED 2.0 for the HTTP Request node. Therefore any users that upgrade to Node-RED 2.0 and have your node installed (or later try to install it) will get errors when using the http-request node.

Could you please take a look at your dependencies and see if you can update the versions so that you are no longer dependent on agent-base before versio 6.0.0

Note this could be a module that you are using has a dependency on agent-base so you might need to check for updates to that module, to help you we've attached your nodes dependency tree below

More details on this issue and the warning message that is now displayed in Node-RED 2.0.2 are on the forum at link https://discourse.nodered.org/t/node-red-2-0-2-released/48767

└─ node-red-contrib-ngrok@2.0.0
   └─ ngrok@4.0.1
      ├─ decompress-zip@0.3.3
      │  ├─ mkpath@0.1.0
      │  ├─ binary@0.3.0
      │  │  ├─ buffers@0.1.1
      │  │  └─ chainsaw@0.1.0
      │  │     └─ traverse@0.3.9
      │  ├─ graceful-fs@4.2.6
      │  ├─ nopt@3.0.6
      │  │  └─ abbrev@1.1.1
      │  ├─ q@1.5.1
      │  ├─ readable-stream@1.1.14
      │  │  ├─ core-util-is@1.0.2
      │  │  ├─ isarray@0.0.1
      │  │  ├─ string_decoder@0.10.31
      │  │  └─ inherits@2.0.4
      │  └─ touch@0.0.3
      │     └─ nopt@1.0.10
      │        └─ abbrev@1.1.1
      ├─ hpagent@0.1.2
      ├─ uuid@3.4.0
      ├─ got@11.8.2
      │  ├─ @sindresorhus&#x2F;is@4.0.1
      │  ├─ @szmarczak&#x2F;http-timer@4.0.6
      │  │  └─ defer-to-connect@2.0.1
      │  ├─ @types&#x2F;cacheable-request@6.0.2
      │  │  ├─ @types&#x2F;keyv@3.1.2
      │  │  │  └─ @types&#x2F;node@16.4.0
      │  │  ├─ @types&#x2F;http-cache-semantics@4.0.1
      │  │  ├─ @types&#x2F;responselike@1.0.0
      │  │  └─ @types&#x2F;node@16.4.0
      │  ├─ @types&#x2F;responselike@1.0.0
      │  │  └─ @types&#x2F;node@16.4.0
      │  ├─ decompress-response@6.0.0
      │  │  └─ mimic-response@3.1.0
      │  ├─ cacheable-request@7.0.2
      │  │  ├─ clone-response@1.0.2
      │  │  │  └─ mimic-response@1.0.1
      │  │  ├─ get-stream@5.2.0
      │  │  │  └─ pump@3.0.0
      │  │  │     ├─ end-of-stream@1.4.4
      │  │  │     │  └─ once@1.4.0
      │  │  │     └─ once@1.4.0
      │  │  │        └─ wrappy@1.0.2
      │  │  ├─ http-cache-semantics@4.1.0
      │  │  ├─ keyv@4.0.3
      │  │  │  └─ json-buffer@3.0.1
      │  │  ├─ responselike@2.0.0
      │  │  ├─ normalize-url@6.1.0
      │  │  └─ lowercase-keys@2.0.0
      │  ├─ cacheable-lookup@5.0.4
      │  ├─ lowercase-keys@2.0.0
      │  ├─ responselike@2.0.0
      │  │  └─ lowercase-keys@2.0.0
      │  ├─ http2-wrapper@1.0.3
      │  │  ├─ resolve-alpn@1.2.0
      │  │  └─ quick-lru@5.1.1
      │  └─ p-cancelable@2.1.1
      ├─ yaml@1.10.2
      └─ @types&#x2F;node@8.10.66

Thanks in advance for looking into this.

Sam

PS Sorry for the templated issue but we've got a number of nodes with the issue so I'm automating the issue creation.