search

sammachin / node-red-contrib-ngrok

ngrok node for node-red
MIT License
7 stars 10 forks source link

add: support ngrok-javascript #32

Closed twocolors closed 10 months ago

twocolors commented 10 months ago

hi this pull support ngrok-javascript and Node-RED >= 2 , nodejs >= 16

twocolors commented 10 months ago

@sammachin ping

sammachin commented 10 months ago

Sorry I’d missed the notification for the PR, I’l talk a look this eve or tmw

On Thu, 25 Jan 2024, at 11:27, D wrote:

@sammachin https://github.com/sammachin ping

— Reply to this email directly, view it on GitHub https://github.com/sammachin/node-red-contrib-ngrok/pull/32#issuecomment-1909967308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABNZ7PPSORXSA4UMQLBVVTYQI6QVAVCNFSM6AAAAABBYABIMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBZHE3DOMZQHA. You are receiving this because you were mentioned.Message ID: @.***>

twocolors commented 10 months ago

add dependabot for npm

sammachin commented 10 months ago

@twocolors I need to do a bit more testing with this, on my initial test just installing this package didn't seem to install the relevent ngrok binary dependency eg @ngrok/ngrok-darwin-arm64 Also need to understand the implications of upgrading a node on a machine that has the old ngrok package installed.

Something seems to be broken/changed with the subdomain field as well, I suspect this is an ngrok change but it would be good to understand this better and see if we can avoid breaking peoples flows

twocolors commented 10 months ago

hm, for me all work fine

twocolors commented 10 months ago

@sammachin have any ideas or suggestion?

russorat commented 10 months ago

PM from ngrok here. Just to clear up any confusion, the latest ngrok-javascript library does not need to download any closed source binaries to run ngrok as previous 3rd party libraries have done. It speaks directly to the ngrok services from your code, eliminating the need for the local ngrok agent.

twocolors commented 10 months ago

@sammachin try this version with ngrok-javascript 1.0.0

sammachin commented 10 months ago

@twocolors I'm going to merge this but then make a change to the domain handling code to avoid breaking installs that currently have the legacy subdomain value set eg just a single string foo that becomes foo.ngrok.io. I'm minded to initially publish this on npm with a beta tag so we can get some feedback on upgrading flows that are using the older versions, I want to avoid breaking anyones flows if I can as that creates a support overhead.

twocolors commented 10 months ago

@sammachin you will public beta on npm?

sammachin commented 10 months ago

yes I published it a couple of days ago https://discourse.nodered.org/t/updated-node-red-contrib-ngrok-3-0-0-beta/85147 38 downloads and no feedback so I'm guessing there arn't any major issues. Maybe give it till the end of the week then do a GA release

sammachin commented 9 months ago

@twocolors @russorat I've published this now as 3.0.2 and updated the node-red flow library I decided to remove the region setting for now as its less useful with GSLB anyway, if there's demand I may bring it back but that would require more work to how the client connects so didn't want to delay any further.