search

sammcewan / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.
Other
253 stars 74 forks source link

New rounded arrow causes a white line artifact on WYPopoverArrowDirectionDown #28

Closed rsanchezsaez closed 9 years ago

rsanchezsaez commented 9 years ago

This is the configuration that causes it:

WYPopoverBackgroundView *popoverAppearance = [WYPopoverBackgroundView appearance];
popoverAppearance.fillTopColor = blueColor;
popoverAppearance.fillBottomColor = blueColor;

See screenshot:

img_8354

Going back to the straight arrow fixes it:

img_8355

maciekish commented 9 years ago

Ill have a look at this

rsanchezsaez commented 9 years ago

I discovered the problem and I'm fixing it. Will submit a pull request soon.

rsanchezsaez commented 9 years ago

Done, see the above pulls request.

@maciekish Thanks for your work! The problem was that the arrow points where being drawn in the wrong order. Additionally, I simplified your code and unified it more with the old pointy arrow code. If you have any questions just ask. ;-)

rsanchezsaez commented 9 years ago

Fix merged! Thanks.