Call Delegate methods should default to `YES`, not `NO`

sammcewan / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.

Other

253 stars 74 forks source link

Call Delegate methods should default to `YES`, not `NO` #42

Closed orta closed 8 years ago

orta commented 9 years ago

Here: https://github.com/sammcewan/WYPopoverController/blob/master/WYPopoverController/WYPopoverController.m#L2780

I'll be doing this in my fork, ( which alas has things that shouldn't really be in master ) but I think the YES is typical behaviour for PopoverControllers.

nemphys commented 9 years ago

Totally agree, delegate methods should always be called.

vitalys commented 8 years ago

WYPopoverController mimics behavior of UIPopoverController, so popoverControllerDidDismissPopover: won't be called if you dismiss popover using dismissPopoverAnimated: method