search

sammcewan / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.
Other
253 stars 74 forks source link

PR: Support modally presented controllers #62

Closed 0x7061 closed 9 years ago

0x7061 commented 9 years ago

I had to change the way the library grabs the keyWindow so that it also works for modally presented controllers. For this I simply removed the rootViewController.view part and referenced _inView directly instead of _inView.window.

Now works for both controllers in a navigation controller and modally presented controllers.

sammcewan commented 9 years ago

Sounds logical. I'll test this out a bit. I'm unsure of the original owner's intentions doing it this way.

sammcewan commented 9 years ago

After some light testing there are some issues with this branch. As seen below: screen shot 2015-06-20 at 2 06 02 pm

I've reverted it in the mean time.