search

sammcewan / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.
Other
252 stars 74 forks source link

Attempt to fix popover rotation #70

Closed portellaa closed 5 years ago

portellaa commented 9 years ago

This is a small change, can sounds like an hack but i don't think it is.

I thinks you could use only the UIApplicationDidChangeStatusBarOrientationNotification to change the popover rotation since this is fired always. From my point of view, the device orientation, it is all the information from the accelerometer, gyroscope and all that stuff, if it is face down, face up, isn't needed to this. Anyway, i left there the notification.

I decide to merge both notification in the same callback and use a queue to sync the rotation. At least, for our problem it seems to fix the problem and it's working like a charm.

Check it as soon as possible, and let us know what you think about this.

Many thanks.

vitalys commented 8 years ago

@portellaa Do you have a test project that can show the original problem? Probably I had such issue, but I'm not sure that I can reproduce it easy.