search

sammcewan / WYPopoverController

WYPopoverController is for the presentation of content in popover on iPhone / iPad devices. Very customizable.
Other
253 stars 74 forks source link

#81: PopoverController Init: Configure temp theme object and inject it to static var #82

Closed ashavit closed 8 years ago

ashavit commented 8 years ago

Fix for issue #81. Each time a WYPopoverConrtoller is init, the static theme var is re-configured. But since there is also an observer on the _theme var, the observer is invoked for every changed theme property during the init, which results in performing the -updateThemeUI method about 20 times in a row.

vitalys commented 8 years ago

Looks good. Thank you

vince4 commented 6 years ago

This PR introduce some crash. CF : issue #86. You should set new theme only once using [self setTheme:theme] instead of _theme = theme to register observer correctly.