search

sammchardy / python-binance

Binance Exchange API python implementation for automated trading
https://python-binance.readthedocs.io/en/latest/
MIT License
6.01k stars 2.2k forks source link

Is this library still maintained? I see 1-2 year PRs still not merged #1134

Open xucian opened 2 years ago

xucian commented 2 years ago

This worries me a bit as I already built a complex system on top of the library. @sammchardy , can I take over the PRs?

Update: actually, I see some activity, but I recommend older PRs to be closed if they're not accepted. Also, I highly recommend refraining from committing to master directly (I was confused when trying to create 2 PRs that were failing after branching from master, only to realize master is ahead of the last release) and only keeping the master for releases and hotfixes, each commit on master automatically ending up with a new release/hotfix-release (CI should be easy to set up)

halfelf commented 2 years ago

Same worries. No issue closed for a long time. I have to fork this lib and create my own binance client.

jon4hz commented 2 years ago

I can recommend https://github.com/LUCIT-Systems-and-Development/unicorn-binance-suite, which is very well maintained and supports the rest and websocket api.

xucian commented 2 years ago

library works well once you fix the bugs yourself via the existing PRs or create your own. I'd like to see more interest from developers as this is a very valuable piece of software, which can even lead to financial freedom for some..

jon4hz commented 2 years ago

to be honest, this repo seems pretty much dead to me. I switched all my scripts to the unicorn binance suit and it works perfectly. Issues are addressed pretty fast and I don't have to worry about fixing the library myself :)

xucian commented 2 years ago

to be honest, this repo seems pretty much dead to me. I switched all my scripts to the unicorn binance suit and it works perfectly. Issues are addressed pretty fast and I don't have to worry about fixing the library myself :)

I'm not comfortable with using a less popular lib. This one is great, only needs some more frequent housekeeping

xucian commented 2 years ago

Sorry, closed by mistake