search

sammchardy / python-binance

Binance Exchange API python implementation for automated trading
https://python-binance.readthedocs.io/en/latest/
MIT License
5.88k stars 2.2k forks source link

Fix for #1250 and #1307 to make limit work for get_historical_klines #1386

Open Kipperlenny opened 6 months ago

Kipperlenny commented 6 months ago

As supposed by https://github.com/sammchardy/python-binance/issues/1250 I added some lines to make the limit parameter work. Without this fix, the function will run forever (while True:...) even if the limit is reached.

I added another testcase for it (start time and limit) and fixed another failing test case (missing url).