search

sammchardy / python-binance

Binance Exchange API python implementation for automated trading
https://python-binance.readthedocs.io/en/latest/
MIT License
6.09k stars 2.21k forks source link

Typo in documentation #370

Closed jtfarks closed 5 years ago

jtfarks commented 5 years ago

Market Data Endpoints >> Get Historical Kline/Candlesticks

The third example is:

# fetch weekly klines since it listed
klines = client.get_historical_klines("NEOBTC", KLINE_INTERVAL_1WEEK, "1 Jan, 2017")

I believe it should be:

# fetch weekly klines since it listed
klines = client.get_historical_klines("NEOBTC", Client.KLINE_INTERVAL_1WEEK, "1 Jan, 2017")
sammchardy commented 5 years ago

What do you know, there is a typo! Probably won't be the last, thanks!

sammchardy commented 5 years ago

Oh, have updated it :)