feature/asyncio: Unclosed client session

[sapph1re]

Describe the bug I simply instantiate AsyncClient like demonstrated in readme, and its usage is always followed with an "Unclosed client session" error.

To Reproduce

import asyncio
from binance import AsyncClient

async def main():
    client = await AsyncClient.create()
    print(await client.get_server_time())

if __name__ == '__main__':
    loop = asyncio.get_event_loop()
    loop.run_until_complete(main())

Output:

Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x0000029492976A58>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x000002949290DE88>, 3463537.656)]']
connector: <aiohttp.connector.TCPConnector object at 0x0000029492976AC8>
{'serverTime': 1566977521778}

Expected behavior Expected not to have errors. Should I somehow gracefully close/destroy AsyncClient?

Environment (please complete the following information):

• Python version: 3.7
• OS: Windows 10
• python-binance: 0.7.3-asyncio, cloned from the repository: 00dc9a978590e79d4aa02e6c75106a3632990e8d

[zenflip]

Yep same here. There's no AsyncClient and also the DepthCacheManager and BinanceSocketManager are elsewhere.

from binance.depthcache import DepthCacheManager
from binance.websockets import BinanceSocketManager

...perhaps?

[sapph1re]

Apparently, it's an error of aiohttp, which is used here. Its ClientSession is recommended to be run in a context manager: https://stackoverflow.com/questions/46112848/python-package-aiohttp-has-a-warning-message-unclosed-client-session

Another way is closing the aiohttp.ClientSession explicitly: await self.session.close() but I'm not sure where exactly it would be good to do it. Make a special class method for that, like stop()? What would be the best approach?

[matze19999]

@sapph1re did you find a fix / workaround for this?

[sapph1re]

@sapph1re did you find a fix / workaround for this?

sorry, my previous (deleted) answer was misleading. I made a stop() method in the exchange wrapper class, which explicitly calls await self._client.session.close() where self._client is the AsyncClient instance.

[gorkem2020]

I'm still getting this error. I guess it has not been fixed.

[Gorgosaurus]

I still get the error

[difrankode]

You need close conection

async def main():
    client = await AsyncClient.create()
    print(await client.get_server_time())
    # all code here
    await client.close_connection() # <--- you need this line. insert it in the end of main function