search

sammchardy / python-kucoin

Kucoin REST and Websocket API python implementation
https://python-kucoin.readthedocs.io/en/latest/
MIT License
352 stars 148 forks source link

Fix get_order_detail bug by removing slash #20

Closed SnoozeTime closed 6 years ago

SnoozeTime commented 6 years ago

The endpoint in self._get for get_order_details had a slash at the beginning. When creating the full path, it returned /v1//order/detail instead of /v1/order/detail.

Fix is just to remove the slash to conform with other methods.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 44.18% when pulling 3d9c3bb1e203bea853b9f1278605d405cf5134e1 on SnoozeTime:develop into fbe90ef8321d6e158b25388faf12b7cc981719a1 on sammchardy:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 44.18% when pulling 3d9c3bb1e203bea853b9f1278605d405cf5134e1 on SnoozeTime:develop into fbe90ef8321d6e158b25388faf12b7cc981719a1 on sammchardy:develop.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 44.18% when pulling 3d9c3bb1e203bea853b9f1278605d405cf5134e1 on SnoozeTime:develop into fbe90ef8321d6e158b25388faf12b7cc981719a1 on sammchardy:develop.

sammchardy commented 6 years ago

Thanks @SnoozeTime, good pick up.