sammielove45 / propgcc

Automatically exported from code.google.com/p/propgcc
1 stars 1 forks source link

An incorrect "symbolic" numeric value does not produce an error #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. Change propeller-load.cfg so that clkmode has an invalid value (e.g. 
"clkmode: foo"
2. Run propeller-load.

What is the expected output? What do you see instead?

I expect to see an error message telling me the symbol is not correct.  
Instead, I see no error message.

What version of the product are you using? On what operating system?

propgcc-0.2.2

Please provide any additional information below.

The error is at line 451 of loader/src/config.c...

Change:

            if (!sym) {
                Error("undefined symbol: %s", id);
                return FALSE;
            }

To:

            if (!sym->name) {
                Error("undefined symbol: %s", id);
                return FALSE;
            }

Original issue reported on code.google.com by tjstefan...@charter.net on 28 Jan 2012 at 8:16

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks for pointing out this bug. I've fixed it as you suggested.

Original comment by dbet...@gmail.com on 28 Feb 2012 at 12:57