Currently doesn't work on macOS, or without STK.

techdragon commented 2 years ago

[ ] Automatically imports STK stuff that is Windows only and also appears to not be free/open software, but since its optional this isn't required.
[ ] Windows specific paths break on macOS (will also break on Linux)
[ ] Also kinda sensitive to the underlying TCL/TK library in use by the python interpreter running the script. Very broken on macOS without a recent version.

I've got a few fixes for some of these, but the easiest way will be to package this up with a proper dependency management file (I've already got the pyproject.toml from setting this up with poetry on my Mac.) but I don't want to shove a big pull request where I package it, and make a big part of the codebase optional without asking if that's going to be accepted first.

sammmlow commented 2 years ago

Thanks for bringing it up! Feel free to make a pull request, and we can review the changes - it'll be very much appreciated since I don't have a Mac or Linux terminal to test it out on; I've had a few big issues before with other Mac and Linux users, especially with imports of STK-related things or the comtypes library (STK app works only with Windows).

Unfortunately that's one shortcoming of TKinter - the GUI isn't agnostic to the user's display settings. Sometimes the widgets take up too much or too little room. Currently the only thing that's been done is to sample the DPI of the user, and scale it accordingly for the matplotlib plots. At present I haven't yet thought of a way to move forward with the clunky GUI though.

sammmlow commented 2 years ago

Could you also upload screenshots of the GUI or any error messages that you observed?

kerel-fs commented 7 months ago

Just submitted a patch solving these issues in Pull Request #9 doing minimal changes.

sammmlow / ORBITM

Currently doesn't work on macOS, or without STK. #6