sammy1881 / homebridge-sengled-bulbs

Homebridge plug-in for Sengled zigged bulbs
2 stars 4 forks source link

Add Adaptive Lighting Support #13

Open RandyTidd opened 2 years ago

RandyTidd commented 2 years ago

I'd like to contribute adaptive lighting support. I have a branch with these changes here:

https://github.com/RandyTidd/homebridge-sengled-bulbs/tree/AdaptiveLighting

I've been running it for a few days, but I'll wait a little while longer to make sure it's stable, and also wait for PR #12 to go in. If anyone wants to try it out, @ me if you find issues.

sammy1881 commented 2 years ago

This looks good to me, no issues so far but the overall response time seems slow. I couldn't figure out why though but my light takes a few seconds to turn on/off using this branch.

RandyTidd commented 2 years ago

I'll take a look at this.

Could you send me your config? I wonder if you have adaptive lighting turned on. I do and I experience this 1-2 seconds, but I thought it was because I was sending two commands (one to set the cached color temp and the other to turn it on) when adaptive lighting is enabled. I think there is a way to combine them, but would like to check if you are seeing something else.