Closed mjh65 closed 1 month ago
The changes involve modifying the visibility of the LUNASVG_BUILD_STATIC
compile definition in the CMakeLists.txt
file. It was previously defined as a private target compile definition for the lunasvg
target, limiting its accessibility. The update changes this to a public definition, allowing it to be used by other targets that link against lunasvg
.
Files | Change Summary |
---|---|
CMakeLists.txt | Changed LUNASVG_BUILD_STATIC from private to public in target compile definitions for lunasvg . |
🐇 In the garden where code does grow,
A change was made, as the compilers know.
From private whispers to a public cheer,
Now all can share in the build, oh dear!
With hops of joy, we celebrate the day,
For now, our targets can play and stay! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
I noticed that there is significant change since 2.4.1 and possibly (I didn't look very closely) that CMake is not going to be supported in the next release? So maybe this fix is no longer relevant? However it might be good if there could be a 2.4.2 release for anyone working with lunasvg in the meantime?
@mjh65 CMake support has been reinstated, and your patch has been applied. I appreciate you bringing this to our attention.
When lunasvg is being used in another CMake project then both projects need to define (or undefine) LUNASVG_BUILD_STATIC to get the required linkage. Change the definition to PUBLIC to export this.
Summary by CodeRabbit
LUNASVG_BUILD_STATIC
definition for better integration with dependent targets.LUNASVG_BUILD_STATIC
compile definition, improving build configurations for linked targets.