search

sammycage / lunasvg

SVG rendering and manipulation library in C++
MIT License
866 stars 124 forks source link

Library is forcefully built as static #38

Closed LHLaurini closed 3 years ago

LHLaurini commented 3 years ago

https://github.com/sammycage/lunasvg/blob/5f4d0388c1259a6acc884cab90fc655ec5fd95a1/CMakeLists.txt#L10

Is there any reason for forcing the library to always be statically linked? Wouldn't it be a better idea to just use BUILD_SHARED_LIBS and allow the developer to choose?

sammycage commented 3 years ago

Is there any reason for forcing the library to always be statically linked?

I explicitly set the library target as STATIC, because public headers do not export any symbols on Windows.

Wouldn't it be a better idea to just use BUILD_SHARED_LIBS and allow the developer to choose?

It will be a good idea. When I have time, I'll work on it. Pull request will be highly appreciated.

LHLaurini commented 3 years ago

I'll give it a shot. Shouldn't take long.