sammypanda / MCJE-PlayerQuests-Plugin

Survival-friendly questing by the players for the players!
GNU General Public License v3.0
4 stars 0 forks source link

Quest diary entries duplicate when a quest is untoggled and retoggled #72

Closed sammypanda closed 2 months ago

sammypanda commented 2 months ago

Description: interacting with a quest NPC has their interaction sparkles remain when they are supposed to disappear.

Steps to reproduce: [in issue title]

Intended: NPC interaction FX should disappear if it's no longer relevant to the quest (like a past interaction). In screenshot below, only the NPC on the right (with the second action) should be highlighted to interact with, but the left side previous NPC is still showing interaction FX.

Image

sammypanda commented 2 months ago

Spot the difference time:

context

[22:25:05] [Server thread/INFO]: the quest in myquest gui: playerquests.product.Quest@46fe2972

working

[22:24:56] [Server thread/INFO]: setting progress of Blarg_15eea801-3dc5-4339-93cf-79f15320067c to action_1
[22:24:56] [Server thread/INFO]: full quest progress gotten: {playerquests.product.Quest@497c3f6c=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@240178b5=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@46fe2972=Connections{next='null, curr=action_1, prev=stage_0}}
[22:24:56] [Server thread/INFO]: full quest progress gotten: {playerquests.product.Quest@497c3f6c=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@240178b5=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@46fe2972=Connections{next='null, curr=action_1, prev=stage_0}}

failing

[22:25:07] [Server thread/INFO]: setting progress of Blarg_15eea801-3dc5-4339-93cf-79f15320067c to stage_0
[22:25:07] [Server thread/INFO]: setting progress of Blarg_15eea801-3dc5-4339-93cf-79f15320067c to action_1
[22:25:07] [Server thread/INFO]: full quest progress gotten: {playerquests.product.Quest@497c3f6c=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@240178b5=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@50759eef=Connections{next='null, curr=action_1, prev=stage_0}, playerquests.product.Quest@46fe2972=Connections{next='null, curr=stage_0, prev=null}}
[22:25:07] [Server thread/INFO]: full quest progress gotten: {playerquests.product.Quest@497c3f6c=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@240178b5=Connections{next='null, curr=stage_0, prev=null}, playerquests.product.Quest@50759eef=Connections{next='null, curr=action_1, prev=stage_0}, playerquests.product.Quest@46fe2972=Connections{next='null, curr=stage_0, prev=null}}
sammypanda commented 2 months ago

Duplicates in B of retoggling quest A in #73