sammypanda / MCJE-PlayerQuests-Plugin

Survival-friendly questing by the players for the players!
GNU General Public License v3.0
4 stars 0 forks source link

Fix release alert always showing #80

Closed sammypanda closed 2 months ago

sammypanda commented 2 months ago

Just uses a different comparator (equivalency operator to .equals function) and more specific parantheses for grouping operations.

This only fixes the issue for releases. If you're on a snapshot, it will report a new version that is older than your current. For example: 0.5.3 it will say the new release is 0.5.2. This is because there isn't a function to evaluate the string as a version. It's just a simple and fast check if the current version is the same as the latest release.

I'm happy with snapshots being a fringe case, they are snapshots after all which shouldn't be considered stable. So an alert pulling back to 'newest' release is fairly appropriate.

Closes #79