search

sammypanda / MCJE-PlayerQuests-Plugin

Survival-friendly questing by the players for the players!
GNU General Public License v3.0
4 stars 0 forks source link

Quest NPCs can be placed on-top of each other, which breaks NPC actions #90

Closed sammypanda closed 1 month ago

sammypanda commented 2 months ago

When two or more NPCs are placed at the same location, the quest spawns both. The earlier NPC gets replaced with the latest. This means that if an action is on an earlier NPC that got replaced, the interaction cannot be played out.

The block here should be a Dirt block: shows a sparkling Birch Log NPC block that cannot be interacted with

sammypanda commented 2 months ago

This is easy to fix by not allowing in the editor.

However, it would be nice to also check any time a save is done. This would mean a manually edited quest won't be susceptible to breaking like this either.

My idea for this part of the issue would be to fix the quest editing mechanisms to save on each change (which is also required by #82). This change would also benefit from an undo button if it's saving on every change.

sammypanda commented 2 months ago

There is nothing in #95 that stops quest NPCs from the same quest (if json edited manually) from being placed in the same location. Maybe can do this in a quest validity check.

sammypanda commented 2 months ago

Didn't add it in validity check, wouldn't be ideal for performance for a use-case that is unlikely anyway (manually editing the template).