search

sammyt / rhumb

URL routing in js
MIT License
4 stars 4 forks source link

Add query parameter object to callback #13

Closed mstade closed 9 years ago

mstade commented 9 years ago

Currently, if you match /foo/{bar} with /foo/wibble?bar=1 the value of bar sent to the callback in the params object will be wibble, and the query parameter is lost. It makes sense for path parameters to take precedence, however we shouldn't lose information so consider adding a second callback parameter specifically for query parameters; alternatively roll up the parameters into a list as #12 says. Unclear what the way forward here is.

mstade commented 9 years ago

This issue was moved to websdk/rhumb#5