search

samnabi / shopkit

Comprehensive commerce solution for Kirby CMS v2
https://shopkit.samnabi.com
Other
99 stars 15 forks source link

New themes #164

Closed enginmurat closed 6 years ago

enginmurat commented 7 years ago

new templates for shopkit

samnabi commented 7 years ago

I'm not sure multiple templates make sense, when all of the Shopkit sites I've seen include heavy customizations of their own.

I will keep this issue open to hear other perspectives.

TimOetting commented 7 years ago

I think it would be very useful to have a template that is as minimalistic as possible. Meaning, no styling, no classes, as few javascript and html elements as possible. This would give me a better starting point for a fully customized shop.

samnabi commented 7 years ago

@TimOetting what would you like to see built into the 'minimalistic' theme? Some things I might keep in:

Or would you rather implement all of these layouts yourself?

TimOetting commented 7 years ago

@samnabi thanks for the reply on this.

I think I would like to just have a simple html frame around all the unique kirby fields that come with shopkit. If that is what you mean by a 'basic layout' I would be happy to see it inside the template. I would leave out all the css stuff because that would require to add classes. There are nowadays so many ways to name css classes, I would just keep it open to the developer to decide how to structure the css by simply leaving it away completely. If you want to describe content blocks inside the template I would prefer HTML comments. I am not sure if I would keep the AJAX cart update functionality in the basic theme. But I think a template that works completely without js would be a preferable solution. It would be nice if there would be a nicely documented API for all those actions that could be utilized by the developers themself if needed. For orders, gallery and slideshow I would stick with a simple ul html list. If there are developers that want to create a theme for shopkit they most likely want to implement their own solution for this kind of content.

Thanks Tim

samnabi commented 7 years ago

Hm, in this case we will still need to change markup (if people are adding their own classes, etc.)

Here's what I propose:

I'll maintain a separate repository with a set of template overrides. These overrides can be dropped in to the site/ folder. They will have very little formatting, and no javascript.

This will function much in the same way as the shopkit-sample-content repository.

This means I'll have to maintain two separate sets of templates, and I'll move as much logic as possible into controllers.

I'll also make the snippets as theme-agnostic as possible.

enginmurat commented 7 years ago

Hello dear When will you do it new theme ?

enginmurat commented 6 years ago

i suggestion responsive grid and clean design...

enginmurat commented 6 years ago

https://victorthemes.com/themes/seese/product-category/decoration/

i suggest similar this design...

samnabi commented 6 years ago

I've decided not to maintain a separate repository with another theme, mainly due to time constraints.