samnabi / shopkit

Comprehensive commerce solution for Kirby CMS v2
https://shopkit.samnabi.com
Other
99 stars 15 forks source link

Image Quality #206

Closed Mojo90 closed 6 years ago

Mojo90 commented 6 years ago

I recognized that the image thumbs are in a very bad quality when uploading images for a product. E.g.:

Is there a setting to use the original ones? When not that the quality is not getting that bad? Because imho that looks really awful with those bad images: http://federleichtdesignatelier.de/shop/prints-als-download

samnabi commented 6 years ago

Yes, there will always be a trade-off between file size and quality.

Here are the lines where image resizing happens. You will have to modify them.

Product detail slider: https://github.com/samnabi/shopkit/blob/fcb1a124c753e6934fa5ce4dd317375cb9b8138c/site/plugins/shopkit/snippets/slider.php#L16

Category thumbnail: https://github.com/samnabi/shopkit/blob/7b07e2b9c99c3962dbe3855b84c9e4cc666890f6/site/plugins/shopkit/snippets/list.category.php#L9

Product thumbnail: https://github.com/samnabi/shopkit/blob/4a2c556e91b90531d30a09ec1ebc959b192f7452/site/plugins/shopkit/snippets/list.product.php#L9

Resize upon file upload in the panel: https://github.com/samnabi/shopkit/blob/518fb6b6eeb0c4e819db9a2134c1c182c72822ed/site/plugins/shopkit/registry/hooks.php#L25

Mojo90 commented 6 years ago

Thank you!