search

samnissen / watir-screenshot-stitch

Extends Watir to take full page screenshots of websites.
MIT License
17 stars 7 forks source link

Remove dependency to ActiveSupport to find geckodriver #52

Closed KrauseFx closed 4 years ago

KrauseFx commented 4 years ago

.constantize is a method defined in ActiveRecord (https://apidock.com/rails/String/constantize) and not available for plain Ruby projects.

Replacing this line with Object.const_get will fix it, and will allow us to run in all environments.

samnissen commented 4 years ago

This is a great catch — thank you @KrauseFx. I should know better than to rescue nil like that, and I will address that in a separate PR.

@sandeepnagra Tests pass with this change. Please can you confirm you're happy with it?

sandeepnagra commented 4 years ago

Nice catch! Looks good to me.