search

samoconnor / InfoZIP.jl

ZIP Archive Interface. Wrapper for Info-ZIP (and ZipFile.jl).
Other
10 stars 9 forks source link

Add ZipFile to REQUIRE #13

Open mohamed82008 opened 6 years ago

samoconnor commented 6 years ago

Thanks for this @mohamed82008,

I've asked about what the best way to handle this is on #pkg-usage on Slack:

InfoZip.jl has no listed dependencies in REQUIRE. It uses system installed InfoZip binaries zip and unizip if it can find them. If there is no local InfoZIP, the ZipFile.jl module is used as a (functional but much slower) backend. A user as submitted a PR asking to put InfoZip int REQUIRE https://github.com/samoconnor/InfoZIP.jl/pull/13 I would rather not pull in InfoZIP.jl in builds where I’m trying to keep size minimal (e.g. AWSLambda deployment).

Is there a way in Pkg3 to express “Requires system installed infozip …or… InfoZIP.jl” ? Or, so say: “Requires InfoZIP.jl on Windows, but not on mac or unix” ?

samoconnor commented 6 years ago

Fredrik Ekre suggested using Requires.jl https://github.com/MikeInnes/Requires.jl https://julialang.slack.com/archives/C67EFTEF3/p1538485783000100

samoconnor commented 6 years ago

... and @aviks suggested that there is a way to make the "requires InfoZIP.jl" a windows-only thing. https://julialang.slack.com/archives/C67EFTEF3/p1538481105000100