samoey17 / mupen64plus

Automatically exported from code.google.com/p/mupen64plus
0 stars 0 forks source link

Fix compile warnings in RiceVideo #24

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I noticed the CFLAGS var in the makefiles doesn't include -Wall. I tried
compiling RiceVideo with -Wall and got a lot of warnings. This issue is to
track cleaning up warnings.

Original issue reported on code.google.com by ebenbl...@gmail.com on 27 Mar 2008 at 8:15

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Yeah the original RiceVideo makefile didn't have -Wall in it.  When I merged the
projects together I saw all those warnings and removed -Wall for 
RiceVideoLinux.  I
agree it would probably be better if it compiled cleanly with -Wall, but it's 
going
to take a fair amount of work to clean all that junk up.

Original comment by richard...@gmail.com on 28 Mar 2008 at 5:04

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
I fixed all the char* to const char* legacy issues for normal compilation and 
debug. This was the majority of problems. We were redefining a char* datatype 
and 
confusing the compiler. Anyway... will commit these soon. 

Adding -Wall now mainly gives comparison of signed to unsigned, and unused 
variables. I should be able to fix that quickly enough.

Original comment by sknau...@wesleyan.edu on 4 Apr 2008 at 12:29

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago

Original comment by sknau...@wesleyan.edu on 4 Apr 2008 at 12:30