search

samoht / assemblage

A collection of tools to manage the configuration of OCaml projects
54 stars 4 forks source link

Merlin support #111

Closed dsheets closed 10 years ago

dsheets commented 10 years ago

What sourcery is this?!

samoht commented 10 years ago

yess!

samoht commented 10 years ago

@dsheets I guess you just want the unit, library and binary build dir.

samoht commented 10 years ago

(I'm happy to merge as-is, though)

dbuenzli commented 10 years ago

Well I'm enclined to say that are already enough things that are only half-working (if not entirely) in assemblage. This raises a lot of questions and I'm not sure the generated .merlin file makes sense. E.g. since we have isolated builds you could find the same cmi in many different _build directories, how is merlin going to cope with that ?

dbuenzli commented 10 years ago

I would really prefer that we get to something with the internal api before we add new tools, since those get in the way when we make changes and I don't think we exactly have the right model internally at the moment.

samoht commented 10 years ago

I agree with you in general. In that specific case I still think that's still a very useful addition (with minor interference with the rest of the code).

dsheets commented 10 years ago

Perhaps I should remove the .merlin now that bootstrap.sh makes one (like Makefile and assemblage.install)?

samoht commented 10 years ago

Thanks David for your patches!