search

samoht / assemblage

A collection of tools to manage the configuration of OCaml projects
54 stars 4 forks source link

Merlin support is broken #112

Closed dbuenzli closed 10 years ago

dbuenzli commented 10 years ago

Sorry but the generated merlin file does not work at all for me. Besides the distclean target was not updated which means that it leaves spurious .merlin files in the test suite. Could we have some QA before merging please.

dbuenzli commented 10 years ago

Well it seems that the old .merlin file no longer works either, maybe it's a problem with merlin itself. The remark about the half done job remains.

dsheets commented 10 years ago

Merlin support is broken

This is not descriptive of your actual problem.

Sorry but the generated merlin file does not work at all for me.

Sorry but this is not a helpful or specific bug report. Please describe what is not working and in what way before lashing out at the proximate cause. Please, open a new issue with a specific bug report.

Besides the distclean target was not updated which means that it leaves spurious .merlin files in the test suite.

This was fixed in 7840531. Where is the test suite? How do you use it? make test tells me it doesn't exist.

Could we have some QA before merging please.

This reads like a question but ends in a period.

dsheets commented 10 years ago

The remark about the half done job remains.

You've got to try harder than this. Did merlin integration break your build? Did it prevent you from getting your work done? Were you not developing on a feature branch? Last time I checked, no release with merlin integration was made.

dbuenzli commented 10 years ago

Le jeudi, 21 août 2014 à 22:20, David Sheets a écrit :

Could we have some QA before merging please. This reads like a question but ends in a period.

Good to see you can recognize punctation. I guess you can then infer what I meant.

Daniel

dsheets commented 10 years ago

I cannot infer what you meant which is why I have asked you to be more specific in your complaints. Are you actually asking for better QA? Are you trying to dissuade people from helping you with this project?

Here are some things you could do to achieve a greater confidence in maintaining the invariants you desire:

  1. Document the test suite and add it to the assemble.ml file.
  2. Specify the build products of assemblage setup in a more declarative manner.
  3. Voice specific concerns regarding contributions so that they can be addressed in a reasonable time frame and without hostility.

I could go on but it would be a waste of time because you are a smart fellow and almost certainly already understand how to achieve greater quality assurance in collaborative software projects.

Finally, it seems unlikely that a tool as integrated with other tools as assemblage can reasonably be developed by one or a small group of developers. For this project to be successful, it must be willing and able to easily evaluate, improve, and accept contributions from its community of users. I suggest thinking about ways to improve this process of integrating contributions as a means to help the project succeed.

samoht commented 10 years ago

The generated merlin file works well for me. @dbuenzli I'm fine to not merge anything before you've finished your refactoring if it helps you: I've merged the previous PR because I know @dsheets is very reactive in case of problems -- and to be fair QA for IDE tools is a pain to have.

Will speak about this at the lab tomorrow.

dbuenzli commented 10 years ago

Le jeudi, 21 août 2014 à 23:05, David Sheets a écrit :

Finally, it seems unlikely that a tool as integrated with other tools as assemblage can reasonably be developed by one or a small group of developers. For this project to be successful, it must be willing and able to easily evaluate, improve, and accept contributions from its community of users. I suggest thinking about ways to improve this process of integrating contributions as a means to help the project succeed.

The problem is that the project is really not in such a state in my opinion, the whole project is a draft at best. The conceptual model that the API exposes is currently not implemented at all and we are already piling features on top of an unsound basis. I made my position clear in this comment on the initial PR:

https://github.com/samoht/assemblage/pull/111#issuecomment-52948814

To be fair Thomas did ask me again privately, I was reluctant but he managed to convince me that this should be merged, but the arguments were more social than technical.

As for the test suite, it is described in the assemble.ml and a make test should invoke it.

Daniel