As_component: when syntax error occurs, make sure to clean up output files

samoht / assemblage

A collection of tools to manage the configuration of OCaml projects

54 stars 4 forks source link

As_component: when syntax error occurs, make sure to clean up output files #116

Closed dsheets closed 9 years ago

dsheets commented 10 years ago

Short-circuit || causes output to be removed after dumpast failure. Subshell is necessary to guarantee removal process also returns an error exit code. Fixes #110.

samoht commented 10 years ago

Thanks! I'll keeping this one on hold for a few days as @dbuenzli is rewriting As_component from scratch. I'll backport your patch when the refactoring lands.

samoht commented 9 years ago

Closing as the initial code has changed quite a bit since then.