Closed dbuenzli closed 9 years ago
Thanks, that's awesome!
Doesn't seem to apply cleanly on master though. Can merge manually later.
Quick update: I've tagged 0.4.0, reverted 2 commits which were conflicting with your branch and I've merged it.
I've run the bootstrap scripts, to generate the new documentation.
I have reviewed the API very briefly, and here are my comments so far:
Building
API is well-designed (I can relate the different concepts to what we discussed this summer) but it is a bit hard to understand why we need all of this for a newcomer. If possible, I'll suggest focus on the Parts
things from the start, and dive into Building
just before presenting the parts who need them, e.g Run
and Parts
.Or maybe it's just a matter of improving the basic section and giving more example, to not scary too much the casual user (i.e. you can describe your project in a few lines, you don't need to know all the details hidden in the Building
modules).
Anyway, that's just a superficial read, I need to read the patches for real, not just skimming the doc. Thanks again for the patch!
Le lundi, 1 décembre 2014 à 01:25, Thomas Gazagnaire a écrit :
I did the mistake on reading the doc linearly. It was a mistake.
Actually I said that for you (as in Thomas Gazagnaire). Not for the end user. If everything is well done most user shouldn't need the building part except maybe for argument bundles. That said we can't shuffle things as we wish because of defs. But, yes the end users docs (basics) is not done yet. It should be done at the end when the api has stabilized, it is my intent to have most build patterns described there on small examples.
Regarding putting preliminaries in separate libraries I think we should keep it simple for now and this means having them integrated.
Daniel
True configuration system, simplification and clarification of the build model and concepts exposed, clear separation between user API, driver API and default driver. Still feels that a lot of work is needed to get to the right API and model, but this may be a good start. The project doesn't bootstrap yet, I didn't have the time to port all the old build logic to the new system, sorry about that but I'm really late now. Will follow up with a few issues on the BT from notes that I have locally.
P.S. Until I make the next release of cmdliner a pin on cmdliner's repo is is needed to compile the project.