samoht / assemblage

A collection of tools to manage the configuration of OCaml projects
54 stars 4 forks source link

META file generation be careful with compiler-libs.toplevel #170

Closed dbuenzli closed 4 years ago

dbuenzli commented 9 years ago

Toplevel support for libraries will likely depend on the compiler-libs.toplevel library for opening modules and installing printers. However in these cases we should not add this library to the requires list in the META file see: https://github.com/dbuenzli/resultv/issues/5#issuecomment-77076501.

How can we detect this condition ? Do we need a new library kind ? Or alternatively the compiler-libs.toplevel package could be marked as a Build usage dependency and META generation should not add such tagged packages to the require list.

dbuenzli commented 9 years ago

Or alternatively the compiler-libs.toplevel package could be marked as a Build usage dependency and META generation should not add such tagged packages to the require list.

Yes actually according to what I wrote in the part documentation that should be the right solution. But this pattern should be mentioned in a FAQ/recipe and the correct behaviour implemented by the META driver (which is non functional at the moment).