samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 17 forks source link

[BUG] You have to provide URL, player's name or file of skin you want. #117

Closed kiberptah closed 2 weeks ago

kiberptah commented 1 month ago

Issue

Describe the bug

When skin_change_timer is set to -1 attempt to change skin (skin set URL) quickly after the previous change results in error "You have to provide URL, player's name or file of skin you want.". I use the same command that worked before (chat - up arrow). After waiting a couple of seconds it changes successfully with the same command. I change skin with URL, file is on the same server that my minecraft server runs on.

It is not reproducible when using "skin set player", only with URL apparently.

To Reproduce

Steps to reproduce the behavior:

  1. Change skin with /set skin URL classic
  2. After skin changes quickly use command again (url can be the same or different)
  3. Observe the error

Logs

If you have any errors, please paste them as well. If possible, please use pasting site.

Yes, but they do not touch skins and I don't have reasons to believe they affect this, mods are mostly for server commands and some specific changes to gameplay (e.g. better combat)

Additional context

Tried with URLs of skins stored on my server and with 3rd party skin websites just to test, same result. I don't have reasons to believe it is some error on my server, but even if it is so, error should reflect it.

kiberptah commented 1 month ago

with skin_change_timer set to >0 issue also reproducible, and it is not the same error that show if trying to change before timeout.

samolego commented 3 weeks ago

Screenshot_20241016_213906 Cannot reproduce

kiberptah commented 3 weeks ago

Screenshot_20241016_213906 Cannot reproduce

What about 0 seconds timer?

samolego commented 3 weeks ago

Screenshot_20241016_215650 That's with 0 seconds.

samolego commented 2 weeks ago

Should be working in 2.5.2