search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 16 forks source link

[BUG] Wrong Skin & GUI become blue #23

Closed barraIhsan closed 3 years ago

barraIhsan commented 3 years ago

Describe the bug So first when i set for example Dream skin it would look like this image It supposed to be not like that, it should look like this Second, when I select a text the gui will turn become blue image

To Reproduce Steps to reproduce the first bug:

  1. Type /skin set player Dream or open GUI (by default k), type Dream and click Set Skin

Steps to reproduce the second bug:

  1. Open GUI (by default k)
  2. Type anything
  3. Select a text

Logs Doesnt result any error in logs

**Are you using any other mods? Yes, this is the list image

samolego commented 3 years ago

The wrong skin is the fault of the ely.by skin proxying ... No idea about the blue GUI though 🤔

barraIhsan commented 3 years ago

I think its because copying the color of selecting to a gui? idk

samolego commented 3 years ago

Lol, that could be the case ... it's still weird :D

ghost commented 3 years ago

The wrong skin is the fault of the ely.by skin proxying ...

Wouldn't it be possible to do it differently? Impersonate used to have wrong skins like FabricTailor but was fixed in this commit: https://github.com/Ladysnake/Impersonate/commit/8bcf7c0027e3ca84e7414a2172a6e9d47b71d0e6 Would it be possible to change FabricTailor to the same skin proxy/source? Maybe a modified version of https://github.com/Ladysnake/Impersonate/tree/master/src/main/java/io/github/ladysnake/impersonate/impl/ServerPlayerSkins.java could work as that is a modified version of your code (https://github.com/samolego/FabricTailor/blob/1.0.0/src/main/java/org/samo_lego/fabrictailor/FabricTailor.java)

I know nothing about Java though so I might have just been writing complete gibberish. Sorry if that is the case.

samolego commented 3 years ago

Since working on this, I found some better methods, but rn I'm a bit busy with other things ...