search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 16 forks source link

[Suggestion] Default skin for all worlds #44

Closed juster-0 closed 2 years ago

juster-0 commented 2 years ago

Add ability to set up custom skin for all worlds by default or at least disable default skin (I always have to type /skin clear to get my minecraft skin). Thanks.

samolego commented 2 years ago

Wait, you don't have default skin set in config but you still get a skin applied on a new world?

juster-0 commented 2 years ago

Sorry, I've just tested. That's only relevant to old mod version (1.6.1), in 1.7.1 works as expected. Anyway is it possible to add ability to set custom skin for all new worlds?

samolego commented 2 years ago

How would it differ from the described default skin option in config?

juster-0 commented 2 years ago

Actually there is no difference, but it quite unobvious that's possible without any documentation. I have had to check fabrictailor.json and edit apply_to_all manually. I think it will be better to have settings in Mod Menu or in FabricTailor GUI, so it will be easier to modify that behavior, especially for non tech players.

samolego commented 2 years ago

Humm, you're right in that regard, editing configs is not really user friendly, especially as GUI could be made easily ,..

samolego commented 2 years ago

image What do you think?

juster-0 commented 2 years ago

Good, but you've missed apply_to_all toggle. And is it possible to duplicate that menu into Mod Menu?

samolego commented 2 years ago

The mod menu will be a bit harder, since there's no player instance there. I'll see what I can do.

samolego commented 2 years ago

This has been partially implemented in 1.8.0