search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 16 forks source link

[BUG] Connection timed out freeze the server #47

Closed masmc05 closed 2 years ago

masmc05 commented 2 years ago

For skin fetching problems

Describe the bug the server freeze for 2 minutes when this mod have an error, may you make it async pls? A clear description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. a player tries to join the server
  2. server freeze (no ticking, ignoring the console)
  3. all the players are disconnected because their client didn't receive the PING/PONG packet
  4. first message after freeze is the tailor's error message, meaning that it just finished that task, not other task (i think it was trying to get his skin)
  5. server works normally, the players can connect back

Logs [12:47:50] [Server thread/ERROR]: [FabricTailor] An error occurred: Connection timed out [12:47:50] [Server thread/INFO]: Volchara5581[*] logged in with entity id 693 at (0.5, 126.0, 0.5) [12:47:50] [Server thread/INFO]: Volchara5581 joined the game [12:47:50] [Server thread/INFO]: Volchara5581 lost connection: Timed out [12:47:50] [Server thread/INFO]: Volchara5581 left the game [12:47:50] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 129411ms or 2588 ticks behind [12:47:50] [Server thread/INFO]: MrMinKitt lost connection: Disconnected [12:47:50] [Server thread/INFO]: MrMinKitt left the game [12:47:51] [Server thread/INFO]: operator lost connection: Disconnected [12:47:51] [Server thread/INFO]: operator left the game [12:47:51] [Server thread/WARN]: handleDisconnection() called twice [12:47:51] [Server thread/INFO]: com.mojang.authlib.GameProfile@665052d7[id=null,name=Volchara5581,properties={},legacy=false] () lost connection: Disconnected [12:47:51] [Server thread/INFO]: com.mojang.authlib.GameProfile@32155e0d[id=null,name=Volchara5581,properties={},legacy=false] () lost connection: Disconnected [12:47:51] [Server thread/INFO]: com.mojang.authlib.GameProfile@34b8e222[id=null,name=Laskairk,properties={},legacy=false] () lost connection: Disconnected [12:47:51] [Server thread/INFO]: com.mojang.authlib.GameProfile@a0c6da6[id=null,name=Laskairk,properties={},legacy=false] () lost connection: Disconnected [12:47:51] [Server thread/INFO]: Laskairk[] logged in with entity id 694 at (9960.513486992751, 75.0, 1804.5230337922756) If you have any errors, please paste them as well. If possible, please use pasting site.

Are you using any other mods?

Additional context

Add any other context about the problem here.

masmc05 commented 2 years ago

[12:47:50] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 129411ms or 2588 ticks behind this line tells the time

masmc05 commented 2 years ago

and also a question, may it be your mod the reason why sometimes the players disconnects but the server still thinks that it is still connected, and mobs may kill them? i'm just still unsure what mod is the reason

samolego commented 2 years ago

Thanks for report!

About "keeping player online"; that might be caused by the server lag? As FabricTailor doesn't mess with the logout ...

samolego commented 2 years ago

I somehow messed the async skin fetching that used to be present ...

masmc05 commented 2 years ago

Thanks for report!

About "keeping player online"; that might be caused by the server lag? As FabricTailor doesn't mess with the logout ...

thanks, then it is another mod

samolego commented 2 years ago

Fixed in 1.8.0