samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 17 forks source link

Replay Mod & Skin Changing Incompatibility #68

Closed KiloPetraGames closed 1 year ago

KiloPetraGames commented 2 years ago

I have noticed a compatibility issue with the Replay Mod. Whenever, my player switches skins using the GUI, nothing changes in game, all of my player's held items and equipped armor vanish from view in the replay.

This can be resolved if all item/armor are individually re-equipped after changing skins. However, this is a consistent issue that will always happen after changing skins in FabricTailor.

As an example, I will be wearing full iron armor and holding a torch, but the second I change skins, everything vanishes and my character looks like they are wearing no armor, and holding no torch. My character is still technically holding/wearing these items, but they're no longer visible unless I re-equip each individual item after changing my skin while recording.

samolego commented 2 years ago

Thanks for report. I think it's due to not sending all the packets upon gameprofile change ...

KiloPetraGames commented 2 years ago

Thanks for report. I think it's due to not sending all the packets upon gameprofile change ...

Is there anything I could change on my end to fix it, or is it something that could be resolved in a patch?

samolego commented 2 years ago

No, that's up to the mod.