search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 17 forks source link

[Feature] Warn about internet conection on `/skin set` #95

Open Apis035 opened 8 months ago

Apis035 commented 8 months ago

Minecraft 1.20.4 Fabric Tailor 2.3.0

Upon entering this command with no internet connection, it will respond with:

Trying to set the skin ... Please wait. Uploading skin. Please wait. You have to provide URL, player's name or file of the skin you want.

Does work fine when having internet connection.

I'm playing on a local LAN with friends with no internet connection, using this mod to set our skins.

samolego commented 8 months ago

This mod doesn't change skin fetching mechanic, it still uses mojang's system. So it needs internet access.

Apis035 commented 8 months ago

Ooh, I thought it wasn't supposed to be like that because of the respond message. It also delayed few seconds before displaying "You have to provide URL, player's name or file of the skin you want." like it is actually doing something. 🤔

Maybe change the error message to indicate that this mod doesn't work without internet connection?

samolego commented 8 months ago

It's doing something but fails to do it ... error mesaage is pretty generic, yeah. Probably shows some info in logs?

Apis035 commented 8 months ago

Yeah, that would be better

LegendaryMouse commented 8 months ago

the error still pops up even with internet connection

LegendaryMouse commented 8 months ago

image

/skin set URL classic "https://cdn.discordapp.com/attachments/1202616582841434132/1221545557164556459/123.png?ex=6612f7f4&is=660082f4&hm=a2bd6aa1dd14eea76cbc226de46dc58e6feeb5646d98f5498dac16f773cfa0b4&"

LegendaryMouse commented 8 months ago

imgur and other servers show same error