search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 17 forks source link

[BUG] HD skins not working (1.20.1 release) #96

Closed Lakeno closed 6 months ago

Lakeno commented 8 months ago

HD skins (128x128) dont work as described in the mod's page. When trying to upload the skin via this link, a red warning saying "You have to provide URL, player's name or file of the skin you want".

This link should be readable, as this another skin from the same source loads fine, and the HD skin is in the correct format.

-not using tlauncher -isolated the mod

Any help is apreciated, thanks for this super helpful mod!

samolego commented 8 months ago

Just to clarify, you're using mod to set skin right?

Lakeno commented 8 months ago

Yes. I'm using "/set skin URL classic [URL]", doing the same for a 64x64 skin works fine.

What I meant by "uploading" was loading the skin into Minecraft, and as "source" I meant both images were uploaded in the same place by me, a Github repository. Sorry for my bad wording

samolego commented 8 months ago

You cannot set HD skin via command. You need to use the client mod.

samolego commented 8 months ago

That's because you won't see hd skin without client mod, so then why bother using the command to change it if you have GUI?

Lakeno commented 8 months ago

I used the command for covinience, thought the command and the GUI did the same thing. Anyways, the GUI doesn't work either, it works fine with 64x skins but it behaves very weirdly with 128x skins: when I try to load the HD skin with an URL, first it loads the Ari default skin, then, if done again, loads a glitchy Steve skin, then if I keep retrying it will load Ari skin for something like half a second then go back to the glitchy Steve skin. If I try to load the HD skin with a filepath nothing will happen, like seen in this video. The mod seems to understand that the URL is from a HD skin, since a message in chat about HD skins will appear, that doesn't happen with filepath though.

A screenshot of the frame where Ari skin is loaded:

fabric tailor issue #96

I'm using the 1.20.1 version, but I tested the latest 1.20.4 version and the issue stays the same.

samolego commented 8 months ago

Thanks for deepdive. I'm not sure what's happening, can you post logs as well?

Lakeno commented 8 months ago

Ok

load in game -> create superflat world -> open GUI -> load 64x skin via URL -> try to load 128x skin via URL and fail (3x) -> load 64x skin via filepath -> try to load 128x skin via filepath and fail (2x) -> alt f4

latest.log

samolego commented 8 months ago

Thanks. Will need to debug this when I have time.

samolego commented 6 months ago

Fixed in 2.4.0