samolego / GolfIV

An anti-exploit attempt for Fabric
https://modrinth.com/mod/golfiv
MIT License
49 stars 13 forks source link

Crash on server boot #32

Closed dandin87 closed 3 years ago

dandin87 commented 3 years ago

All of Fabric 3 2.7.x Dev pack Turns out we are starting to get some players using that book and quill dupe glitch, or more likely doing it with wurst. So figured it was time to test your mod out. Crash from the log https://paste.alloffabric.com/jexuviqefu.sql Simply removing "illegal_items.CompoundTagMixin_SizeCheck", from golfiv.mixins.json inside the jar allowed it to load.

[00:11:02] [main/FATAL]: Mixin prepare failed preparing illegal_items.CompoundTagMixin_SizeCheck in golfiv.mixins.json: org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException The specified mixin 'org.samo_lego.golfiv.mixin.illegal_items.CompoundTagMixin_SizeCheck' was not found org.spongepowered.asm.mixin.transformer.throwables.InvalidMixinException: The specified mixin 'org.samo_lego.golfiv.mixin.illegal_items.CompoundTagMixin_SizeCheck' was not found

You have 5 mixins declared in your illegal_items part of golfiv.mixins.json "illegal_items.CompoundTagMixin_SizeCheck", "illegal_items.ItemStackMixinCast_ItemStackChecker", "illegal_items.PlayerInventoryMixin_IllegalsCheckInsert", "illegal_items.ServerPlayNetworkHandlerMixin_CreativeItemsCheck", "illegal_items.ServerPlayNetworkHandlerMixin_IllegalsCheckSlot", but you only have 4 of those mixins here https://github.com/samolego/GolfIV/tree/golfive/src/main/java/org/samo_lego/golfiv/mixin/illegal_items

samolego commented 3 years ago

Wait, you removed the class from the jar? It's totally logical that it crashes then ... 🤔 If you don't need the check, just turn it off.

dandin87 commented 3 years ago

No, you don't have a class in the mod. I removed the line in the golfiv.mixins.json after getting the error. Have you tested your released jar on a server? It does not boot....

samolego commented 3 years ago

Oh, I'm sorry 😞 ... Yes, that's right, seems like I forgot to add the file to git as Spaceclouds has mentioned ...

samolego commented 3 years ago

It actually turned out that this was a temp mixin ... Thanks for reporting!