search

samolego / GolfIV

An anti-exploit attempt for Fabric
https://modrinth.com/mod/golfiv
MIT License
49 stars 13 forks source link

Suggestion: Only make necessary changes to the enchantments of items #33

Open WaffleTraits opened 3 years ago

WaffleTraits commented 3 years ago

Currently, any item with an illegal enchantment (i.e., unbreaking 10 pickaxe) has all of its enchantments removed. My proposed change is to change this behavior so that these items would not have all of their enchantments removed, but rather set to their maximum legal limit (in the case of the unbreaking pickaxe example, it would simply set the enchantment level to 3). This would be very helpful in preserving the enchantment while still preventing such an absurd level of it being used. In the case of disallowed enchantments on an item (for example, diamond boots with sharpness and unbreaking), only the illegal enchantment(s) should be removed.

samolego commented 3 years ago

I don't really know where this would be useful ... If enchantments were applied illegally, what's the point of keeping them?

spaceclouds42 commented 3 years ago

^^^ The only way to get those levels in survival is by getting it from commands/creative, which means that the item itself is also very likely to be illegally obtained, meaning all of its enchantments are (most likely) illegal.

WaffleTraits commented 3 years ago

^^^ The only way to get those levels in survival is by getting it from commands/creative, which means that the item itself is also very likely to be illegally obtained, meaning all of its enchantments are (most likely) illegal.

Personally, I run an anarchy server. Previous administration left some loose ends with some illegally enchanted items on the loose and it would be nice for players to get to keep as many of their enchants as possible while still removing problematic enchantments. Additionally, my server has some voting item rewards that have unnatural enchants, so it's a bit of a bummer when every enchant is lost when really only 1 or 2 need changing/removing

spaceclouds42 commented 3 years ago

voting item rewards that have unnatural enchants

Then you should probably disable the enchant check altogether, as that would mean the voting reward is just a normal item when a player pick it up...

WaffleTraits commented 3 years ago

Do you think it would be possible to add more config options to have an even greater degree of control over what features are active? Right now items are grouped under just a few options, might be a good idea to have more config entries for stuff like enchantments, stacked items, etc.; that way, users have a finer degree of control.

spaceclouds42 commented 3 years ago

Perhaps an ignoredNBT list for survival as well? could ignore Count, Potion, Enchantments, etc.