samolego / GolfIV

An anti-exploit attempt for Fabric
https://modrinth.com/mod/golfiv
MIT License
49 stars 13 forks source link

Fix/Insufficient NBT Patch #43

Closed Ampflower closed 3 years ago

Ampflower commented 3 years ago

This PR aims to fix insufficient NBT being passed for various items at various states, and to also efficiently remove unnecessary NBT in the event of the packet being a potential client kicker.

Goals

Ampflower commented 3 years ago

This is now at a state where most major issues caused by insufficient NBT should be resolved for vanilla items. Modded items will likely still be broken to the client if they rely on any NBT to render. Some of the fixes aren't ideal however, but it makes for a better overall experience to the player.

There is also an unrelated fix included relating to data tracking due to it breaking the spyglass. However, a concurrent modification exception was thrown, full cause unknown due to it being caught by Netty. It's possible that the changes to the original tracker list isn't sound as it's shared with the server thread.

samolego commented 3 years ago

Thank you so much for the contribution!