samolego / GolfIV

An anti-exploit attempt for Fabric
https://modrinth.com/mod/golfiv
MIT License
49 stars 13 forks source link

Fixes for textured heads & creative inventories #58

Closed Ampflower closed 2 years ago

Ampflower commented 2 years ago

Fixes #41 - Creative inventories no longer get inadvertently sanitised for preexisting items by both patchItemKickExploit and removeCreativeNbtTags Fixes #48 - Item names and heads show as expected now. Needs verification for #45 for as this may fix the issue.

Ampflower commented 2 years ago

Moving a head around in the inventory, for some reason, the Display tag is not getting sent. Although, interestingly, this only happens in the creative inventory. Other inventories don't show this effect. This might be due to a disparity of usage within packets for open inventories, although the issue only showing itself on the main inventory makes me wonder otherwise.

Ampflower commented 2 years ago

Force-push was to make the history more sane, and to revert the change to ItemStackChecker#fakeStack.

The one significant change from before the force-push is that usage of fakeStack in patchItemKickExploit was replaced with inventoryStack.

Ampflower commented 2 years ago

Fixed a typo and now have made crossbows send correct data to all clients.