search

samolego / SimpleAuth

Simple authentication mod for Fabric or Forge servers.
https://modrinth.com/mod/SimpleAuth
MIT License
39 stars 14 forks source link

Allow SimpleAuth's Database to Support Simultaneous Servers #22

Closed amnotbananaama closed 4 years ago

amnotbananaama commented 4 years ago

Is your feature request related to a problem? Please describe. I don't know of any other Authentication mod that supports Fabric servers. Unfortunately, on server networks (such as BungeeCord or Velocity) Simple Auth runs into an issue.

It seems like the database is only designed to support one instance of Simple Auth accessing it at a time. The log prints out Unable to acquire lock on '[...]/mods/SimpleAuth/levelDBStore/LOCK'.

I am requesting this because I'd like for players to be able to log into the same server in the network that they logged out of. This requires them to be able to enter their Simple Auth password on every server in the network.

Describe the solution you'd like A config option, and support for a database format where multiple servers can access the database simultaneously. Server administrators could choose between the current format, or this new one.

Describe alternatives you've considered 1) Deal with it, and have users log into the same server each time.

2) Use another Authentication plugin that supports Fabric servers (I don't know of any).

Additional context Thank you very much for not only creating this mod, but taking the time to read a large feature request. If this isn't something you are able to do or interested in implementing, I totally understand. If this is a question of time, I am happy to discuss commission, or leave this open to Pull Requests. Thank you!

samolego commented 4 years ago

Hi, thanks for the suggestion.

It seems like the database is only designed to support one instance

Yes, that's completely true. It wasn't designed with bungeecord stuff in mind, mostly because I haven't thought of it and all I know about bungee is that it's something that exists :D.

Does that mean that it would need to be able to access the same database from different servers? If so, it could maybe be solved by using a different database, e.g. MySQL, maybe even MongoDB?

amnotbananaama commented 4 years ago

If so, it could maybe be solved by using a different database, e.g. MySQL, maybe even MongoDB?

I think so, I’m not sure if there are any potential concurrency concerns or race conditions. I’m not aware of any, I’m forwarding all player data so there is only ever one player with the same UUID/username at a time.

Edit: At the moment, I'm currently using a symlink since all of the servers in my network are on the same machine. This will hopefully not always be true in the future, so it would be awesome if the database could also be remote and the user provided credentials (like Spigot plugins).

samolego commented 4 years ago

I'll probably go with MongoDB, since the deafult LevelDB is a no sql db as well.

so it would be awesome if the database could also be remote and the user provided credentials

Yeah, it'll be available in the config.

samolego commented 4 years ago

This has been implemented in 1.7.0