search

samos123 / docker-drupal

Drupal image based official php image, database information should be passed by environment variables or linked container. Drush is included
34 stars 10 forks source link

Postpone volume decision to end user #11

Closed cerisier closed 9 years ago

cerisier commented 9 years ago

As per discussion in #10

cerisier commented 9 years ago

Do you need anything else to validate the merge ?

moul commented 9 years ago

Looks good to me :+1:

funkyfuture commented 9 years ago

i'd appreciate some explicit words of wisdom how data persistance would be achieved in the README.md

also, can you please adjust the setting of filepermissions in entrypoint.sh:

last, but not least, please squash the commits into one, like explained here: https://github.com/samos123/docker-tutum-drupal/pull/3#issuecomment-81680887

funkyfuture commented 9 years ago

closed by 5b82ba44b41b7807e663b2ea1c8cd5ccf9a258d1

samos123 commented 9 years ago

funky please leave the original author in the commit message if you use his changes.

funkyfuture commented 9 years ago

i just made a commit from scratch since there was no reaction and it seemed rather urgent to undo my changes.

no harm intended.