search

samos123 / docker-drupal

Drupal image based official php image, database information should be passed by environment variables or linked container. Drush is included
35 stars 11 forks source link

Allow change of admin account name from an environment variable #28

Closed ptt-homme closed 9 years ago

ptt-homme commented 9 years ago

This is the logical suite of previous PR.

ptt-homme

ptt-homme commented 9 years ago

It's already done #27, that's why I had this PR. To me it was not logical to be able to customize password and not possible to change the username. You can merge both PR.

I like this docker setup and it would be nice if we can make it available for development purpose as asked in #18. I'm free to make it evolved.

ptt-homme.

samos123 commented 9 years ago

Can you rebase against latest master?

ptt-homme commented 9 years ago

Yes, I will do it in an hour or two.

ptt-homme commented 9 years ago

Done!

funkyfuture commented 9 years ago

while you're at it, i think these variables, especially the admin-password, is not only to be considered during site-install, but also when bootstrapping to an existing instance. as a password-reset-feature.

samos123 commented 9 years ago

Let's merge this first and tackle the new functionality in a new patch (password-reset-feature). This way we can test them independently and makes reviewing easier per changeset.

+1 on me. Let me know if you think it's ready to merge.

On Fri, Jul 24, 2015 at 12:34 AM, Frank Sachsenheim < notifications@github.com> wrote:

while you're at it, i think these variables, especially the admin-password, is not only to be considered during site-install, but also when bootstrapping to an existing instance. as a password-reset-feature.

— Reply to this email directly or view it on GitHub https://github.com/samos123/docker-drupal/pull/28#issuecomment-124161616 .