search

sampad1370 / lidgren-network-gen3

Automatically exported from code.google.com/p/lidgren-network-gen3
0 stars 0 forks source link

Duplicate messages not being dropped for Unreliable and UnreliableSequenced #163

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.Send Unreliable or UnreliableSequenced messages using a duplicate packet 
simulator

What is the expected output? What do you see instead?
Duplicate messages should be dropped for all delivery methods however that is 
not happening for Unreliable and UnreliableSequenced

What version of the product are you using? On what operating system?
r342. Windows 8.

Please provide any additional information below.
Workaround for UnreliableSequenced:
    In NetUnreliableSequencedReceiver.cs:

            Change this:
                  if(relate < 0)
                       return; // drop if late
            To:
                  if(relate <= 0)
                       return; // drop if late OR duplicate

Original issue reported on code.google.com by deadpoly...@gmail.com on 6 Feb 2014 at 7:00

GoogleCodeExporter commented 9 years ago 
Oi! Nice find! There was also a bug in the latency simulation testing code 
which prevented me from seeing this bug when JUST turning on simulated 
duplicates. The checked in fixed differs from the proposed, but the end result 
is the same - the wrong number was passed into the RelativeSequenceNumber 
method. Fixed in revision 351, and I will also create a new distribution.

Original comment by lidg...@gmail.com on 7 Feb 2014 at 8:20