search

sampaiodiego / rocket.chat.app-poll

Rocket.Chat App for creating polls.
MIT License
50 stars 39 forks source link

Feature request: Allow voting in read-only rooms #46

Open lucymk opened 4 years ago

lucymk commented 4 years ago

@sampaiodiego I haven't looked into the underlying stuff, maybe this is nigh on impossible - or maybe it should be working and there's a bug!

Let me know what you think 😄

sampaiodiego commented 4 years ago

this is an interesting use case. for v2 I think the only issue is with app user's permissions, since its him who create and edit the message to show the votes, that might be the problem with https://github.com/sampaiodiego/rocket.chat.app-poll/issues/33 as well.

need a proper test and if that's the case just need to document it somewhere (and maybe give the user an alert about it) ;)

vblg commented 4 years ago

The problem is most likely due to Poll user rights. I made it admin and was able to create a vote in a read-only room. Sorry for my English.

andreas-it-dev commented 4 years ago

it definitely is the app role permission.. give it the permission to post in read-only and you are good to go.. no need to give it admin

sampaiodiego commented 4 years ago

thanks @awunder for taking a look .. I didn't have time to proper look into this.

Even if I can't fix these errors, I need to add some error handling, show somewhere the error message if an error occurred

andreas-it-dev commented 4 years ago

yeah, some user feedback would be great.. i "figured out" why it wont post the poll via issue search and finding this issue :)