search

sampart / WhiteOctoberSwiftMailerDBBundle

A bundle to facilitate SwiftMailer spooling messages to a database
31 stars 18 forks source link

start transport only if there is an email to send #25

Closed agallou closed 6 years ago

agallou commented 6 years ago

Transports like the Swift_Transport_AbstractSmtpTransport start the connexion during the start method.

So when running the swiftmailer:spool:send command the connexion is made to the SMTP even if there no mail to send.

In order to avoid that the start method is called only after getting the list of mail to send.

sampart commented 6 years ago

Thanks @agallou; nice change!

agallou commented 6 years ago

Thanks for the merge @sampart . Did you plan to do a new release ?

sampart commented 6 years ago

@agallou Would a new release be helpful for you? Very happy to do one if you need one.

agallou commented 6 years ago

@sampart yes, it would be very helpful, it will, at @Decitre-Interactive, allow us to use a tag instead of using our fork.

sampart commented 6 years ago

@agallou, @Decitre-Interactive Done: https://github.com/whiteoctober/WhiteOctoberSwiftMailerDBBundle/releases/tag/1.1.1 Thanks again

agallou commented 6 years ago

perfect, thank you !